ArduPilot / ArduPilot/apm_planner
Extended tuning screen throttle PIDs not refreshed
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 552
- Forks
- 483
- PR merge metrics
- No merged PRs in 30d
Description
I yesterday had a crash with my IRIS. After detailed analysis of the logfile and params I found that all throttle PIDs were 0. Before the flight, I set the CH7 option through AP2's extended tuning screen.
I did some testing today and found that when clicking refresh, the PIDs in the extended tuning screen were not updated from the vehicle reliably, leading to the throttle PIDs being 0 when I wrote the data back to my IRIS. There should be some kind of safeguard e.g. prevent editing of the values (grey out) until all PIDs have been reliably loaded from the vehicle and there should also be an indicator indicating if all values have been reliably written to the vehicle. Maybe even a verify after write?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the extended tuning screen's refresh and write-back behavior, reproducing the throttle PID problem with the vehicle and comparing the displayed values with the logfile and parameters. Done means refreshed PIDs are reliably loaded before editing, the interface indicates read/write status, and verification or an equivalent safeguard prevents zero values from being written unnoticed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100