ArduPilot / ArduPilot/MissionPlanner

Mission Planner silently accepts nonsensical numbers based on locale

Open
#2,567 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
C#
Stars
2.4k
Forks
2.9k
Avg merge
19h 16m
Merged PRs (30d)
4

Description

I have the latest version of MP and was trying to add a parameter as "12.34". Since I am in a locale where commas denote decimals, MP decided to silently parse that number as "1234", which is very much the wrong thing to do.

As people don't generally enter thousands separators in parameters, MP should parse both a comma and a period as a decimal separator, to reduce the possibility of such errors.

Related: #128

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing parameter entry with "12.34" in a comma-decimal locale, then trace the Mission Planner code that parses entered parameter values. The issue is done when comma and period decimal separators are handled without silently turning the value into 1234, with behavior covered by an appropriate regression test if the project has one.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.