ArduPilot / ArduPilot/MissionPlanner

Wizard battery monitor step doesn't pick up existing values and disables monitor

Open
#1,623 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
2.4k
Forks
2.9k
Avg merge
19h 16m
Merged PRs (30d)
4

Description

#### Issue details

If I rerun the wizard the _Battery Monitor_ step fails to pickup the current values and if you don't set them again the battery monitor will end up disabled.

---

Let's run through the steps. Here I've set the various values in the _Battery Monitor_ step when running the wizard for the first time:
![9-b-battery-monitor](https://user-images.githubusercontent.com/5216161/28844081-c04dfc28-7703-11e7-9073-ca6ea9897f8c.png)

When I exit out of the wizard and check the _Battery Monitor_ section I see the _Monitor_, _Sensor_ and _APM Ver_ correctly set as expected:
![10-good-configured-battery-monitor](https://user-images.githubusercontent.com/5216161/28844139-f1746634-7703-11e7-8066-8f3d537f2ce7.png)

If I restart the wizard and step forward to the _Battery Monitor_ step I see that it's retrieved the the battery size (3700) correctly but not the autopilot version or sensor:
![10-wizard-rerun-doesnt-pickup-curent-settings](https://user-images.githubusercontent.com/5216161/28844172-1284eec0-7704-11e7-8089-5ac1e8afec57.png)

If I do nothing (i.e. don't press _Next_ or update any of the fields) and simply exit the wizard and return to the _Battery Monitor_ section I find that the _Monitor_ value has switched from _Voltage and Current_ to _Disabled_:
![14-bad-voltage-and-current-monitoring-disabled](https://user-images.githubusercontent.com/5216161/28844220-3d5035e2-7704-11e7-9961-54d670d0a02e.png)

---

While I'm here - thanks Michael for creating an amazing piece of software :smile: And sorry that the first issue that I logged against MP (#1620) wasn't properly researched. And also apologies for not digging into the code to look for a fix - I try to contribute to the OS projects that I benefit from but I'm more a Linux / Java person so I don't have a nice C# setup for investigating deeper.

#### Version
1.3.49

#### Platform
[ ] All
[ ] AntennaTracker
[ * ] Copter
[ ] Plane
[ ] Rover
[ ] Sub

#### Airframe type
X quad

#### Hardware type
Pixhawk 1

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the issue in the Mission Planner wizard using the Battery Monitor step and the Copter configuration described in the report. Trace how the existing battery size, autopilot version, sensor, and monitor values are loaded and saved; done means rerunning and exiting the wizard preserves all four configured values instead of disabling monitoring.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.