ArduPilot / ArduPilot/MissionPlanner

incorrect default params in SITL

Open
#1,607 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
2.4k
Forks
2.9k
Avg merge
19h 16m
Merged PRs (30d)
4

Description

This was noticed by @lthall, but I have reproduced as well with MP 1.1.6330.31130

When using quadplane frame in MP SITL, the default parameters don't come out right.
The most noticeable is the accel offsets aren't set, so you can't arm, but other more significant parameters are wrong too, such as Q_ENABLE=0
The right params are here:
https://github.com/ArduPilot/ardupilot/blob/master/Tools/autotest/default_params/quadplane.parm
The mapping of what param files should be used for each vehicle type is in the python code here:
https://github.com/ArduPilot/ardupilot/blob/master/Tools/autotest/pysim/vehicleinfo.py
maybe that needs to be moved into something like a JSON or XML file?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by comparing the Mission Planner SITL quadplane setup with Tools/autotest/default_params/quadplane.parm and the vehicle-to-parameter mapping in Tools/autotest/pysim/vehicleinfo.py. Reproduce the MP SITL configuration using the reported version, then verify that the quadplane defaults include the accelerometer offsets, Q_ENABLE=1, and the other values from quadplane.parm.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, python
Domain
desktop, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.