ArduPilot / ArduPilot/MissionPlanner

Wrong Options displayed in Full Parameter List

Open
#1,604 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
2.4k
Forks
2.9k
Avg merge
19h 16m
Merged PRs (30d)
4

Description

#### Issue details
In "Full Parameter List", the Options column is showing the wrong information.

For Q_FRAME_CLASS in particular, it's showing

> 0:Quad 1:Hexa 2:Octa 3:OctaQuad 4:Y6

while it should be what's here:

> enum motor_frame_class {
> MOTOR_FRAME_UNDEFINED = 0,
> MOTOR_FRAME_QUAD = 1,
> MOTOR_FRAME_HEXA = 2,
> MOTOR_FRAME_OCTA = 3,
> MOTOR_FRAME_OCTAQUAD = 4,
> MOTOR_FRAME_Y6 = 5,
> MOTOR_FRAME_HELI = 6,
> MOTOR_FRAME_TRI = 7,
> MOTOR_FRAME_SINGLE = 8,
> MOTOR_FRAME_COAX = 9,
> MOTOR_FRAME_TAILSITTER = 10,
> MOTOR_FRAME_HELI_DUAL = 11,
> MOTOR_FRAME_DODECAHEXA = 12,

as per https://github.com/ardupilot/ardupilot/blob/master/libraries/AP_Motors/AP_Motors_Class.h#L32

So right now I'm flying with a value of 4, because my vehicle is an OctaQuad, while MP thinks it's a Y6.

#### Version
1.3.48 build 1.1.6330.31130

#### Platform
[ ] All
[ ] AntennaTracker
[ ] Copter
[X] Plane
[ ] Rover
[ ] Sub

#### Airframe type
X8 quadplane

#### Hardware type
Pixhawk 1

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at Mission Planner's Full Parameter List handling for Q_FRAME_CLASS and compare its displayed Options values with the motor_frame_class enum in libraries/AP_Motors/AP_Motors_Class.h. Done means the list shows the enum's correct values, including OctaQuad as 4 and Y6 as 5, for the reported Plane X8 quadplane case.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.