ArduPilot / ArduPilot/MissionPlanner
Some Clean up Items I think are needed
- Dominant language
- C#
- Stars
- 2.4k
- Forks
- 2.9k
- Avg merge
- 19h 16m
- Merged PRs (30d)
- 4
Description
app.config: change DIYDRONE to ArduPilot, Remove parameter.pde from list as they are blank anyway.
ConfigArducopter: for 3.4 dev
`RATE_PIT_FF.setup(0, 0, 1, 0f, new[] { "RATE_PIT_FF", "ATC_RAT_PIT_FILT" }, MainV2.comPort.MAV.param);
RATE_RLL_FF.setup(0, 0, 1, 0f, new[] { "RATE_RLL_FF", "ATC_RAT_RLL_FILT" }, MainV2.comPort.MAV.param);
RATE_YAW_FF.setup(0, 0, 1, 0f, new[] { "RATE_YAW_FF", "ATC_RAT_YAW_FILT" }, MainV2.comPort.MAV.param);`
Remove scaling for IMAX parameters:
`RATE_RLL_IMAX.setup(0, 0, 1, 0f, new[] { "RATE_RLL_IMAX", "ATC_RAT_RLL_IMAX" }, MainV2.comPort.MAV.param);
RATE_YAW_IMAX.setup(0, 0, 1, 0f, new[] { "RATE_YAW_IMAX", "ATC_RAT_YAW_IMAX" }, MainV2.comPort.MAV.param);
RATE_PIT_IMAX.setup(0, 0, 1, 0f, new[] { "RATE_PIT_IMAX", "ATC_RAT_PIT_IMAX" }, MainV2.comPort.MAV.param);`
Set increment value to zero to get increment value from parameter file.
MavlinkNumericUpDown:
`if (Increment == 0)
{
double Inc = 0;
if (ParameterMetaDataRepository.GetParameterIncrement(ParamName, ref Inc, MainV2.comPort.MAV.cs.firmware.ToString()))
Increment = (float)Inc;
}`
ParameterMetaDataRepository:
`public static bool GetParameterIncrement(string nodeKey, ref double inc, string vechileType)
{
string incrementAmt = ParameterMetaDataRepository.GetParameterMetaData(nodeKey, ParameterMetaDataConstants.Increment,
vechileType);
if (incrementAmt.Length == 0)
return false;
float Amt = 0;
float.TryParse(incrementAmt, NumberStyles.Float, CultureInfo.InvariantCulture, out Amt);
inc = Amt;
return true;
}`
Contributor guide
No contributing guide indexed for this repository
Research direction
Locate app.config, ConfigArducopter, MavlinkNumericUpDown, and ParameterMetaDataRepository. Review the listed 3.4-dev mappings and parameter metadata flow, then verify that the requested cleanup, IMAX scaling changes, and metadata-derived increments are all represented consistently; the issue names no tests to run.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- desktop
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100