Arastais / Arastais/GlobalObjectiveSystemGS

Top performer completion percentage changes after victory

Open
#12 0 comments 0 reactions 0 assignees View on GitHub
bug high priority medium
Dominant language
Squirrel
Stars
1
Forks
0
PR merge metrics
No merged PRs in 30d

Description

If, after any company achieves a victory (beats the objective), any other company after that also achieves a victory, the percentage completion for the top performer goal changes to an incorrect value for all previously victorious companies. The value shouldn't be updated/changed at all once a player is victorious.

This may have to do with how the goal for top performer isn't marked as completed for a company who's achieved victory. Thus, the fix may be as simple as marking all company's objectives complete when they achieve victory.
(screenshot will be added when bug is spotted in-game again)

Contributor guide

No contributing guide indexed for this repository

Research direction

No files, tests, or entry points are named. Reproduce the issue in OpenTTD with multiple companies achieving victory in sequence, then trace the top performer objective completion state; done means each previously victorious company's completion percentage remains unchanged after later victories.

Written by the indexing model from the issue text.

Assessment

Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.