AppImage / AppImage/appimage.github.io

Avoid a certain class of potential fails in Shell scripts

Open
#267 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
374
Forks
769
Avg merge
4d 10h
Merged PRs (30d)
8

Description

https://github.com/AppImage/appimage.github.io/blob/7c9d05f632ac1cfd9e128ab7c6be31ffa6c91e73/code/worker.sh#L97

Re-writing this line as

if [ x$TYPE == x2 ] ; then

avoids Travis error messages like *"code/worker.sh: line 97: [: -eq: unary operator expected"* in case $TYPE is empty.

Same is true for https://github.com/AppImage/appimage.github.io/blob/7c9d05f632ac1cfd9e128ab7c6be31ffa6c91e73/code/worker.sh#L118

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.