ApeWorX / ApeWorX/web3.py

Inject accounts into `web3.eth.accounts` and web3.eth.getAccounts()`.

Open
#853 5 comments 2 reactions 0 assignees View on GitHub
priority: p3 nice to have
Dominant language
Python
Stars
5.5k
Forks
1.7k
Avg merge
3d 10h
Merged PRs (30d)
2

Description

### What was wrong?

It's useful to use `web3.eth.accounts` for things like:

- list of accounts to select from.
- pre-check for some pre-condition that is account based.
- auto selection for some automated criteria.

Acocunts used with the new in-flight transaction signing middleware will not show up in this list.

### How can it be fixed?

Add a conditional to the constructor for the transaction signing middleware that when set truthy will inject any addresses it can sign for into the returned accounts list. Logic should include checks to ensure that addresses are not duplicated in the returned list.

link #649

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.