ApeWorX / ApeWorX/web3.py

Add more transaction tests

Open
#3,707 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
5.5k
Forks
1.7k
Avg merge
3d 10h
Merged PRs (30d)
2

Description

We don't seem to be testing certain transaction params. It isn't really our job to test clients via our library, but we should be testing at least one case of each of these to make sure formatters are working correctly for every transaction field.

Some that come to mind are `eth_sendTransaction` and `eth_sendRawTransaction` tests for each of:

- Sending access lists in type 1 transactions
- Sending access lists in type 2 transactions
- Sending access lists in type 4 transactions - perhaps just creating access lists locally for the transactions we are already sending in this test and attaching them to each of the transactions we send (both raw and send). This should test the full formatters for type 4 txs

Are blob transactions missing any obvious cases? 👀

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.