ApeWorX / ApeWorX/web3.py

refactor creation of Filter objects when created with an existing `filter_id`

Open
#2,733 1 comment 0 reactions 0 assignees View on GitHub
priority: p2 normal
Dominant language
Python
Stars
5.5k
Forks
1.7k
Avg merge
3d 10h
Merged PRs (30d)
2

Description

### What was wrong?

When creating a new filter object with an existing `filter_id`, the `select_filter_method` function in `web3/_utils/filters.py` uses a custom error class to pass the `filter_id` up to the appropriate `retrieve_[blocking|async]_method_call_fn` function in `web3/module.py`. This feels like a convoluted way of doing it that could be improved on.

### How can it be fixed?

Not sure, but open to suggestions.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.