ApeWorX / ApeWorX/web3.py

raise revert reason on transact, sendRawTransaction

Open
#2,593 1 comment 0 reactions 0 assignees View on GitHub
priority: p2 normal v7
Dominant language
Python
Stars
5.5k
Forks
1.7k
Avg merge
3d 10h
Merged PRs (30d)
2

Description

* Version: 6.0+

### What was wrong?
The `revert` reason does not get raised for `transact`, or `sendRawTransaction`. I think it should.

### How can it be fixed?

It may be as simple as adding the methods to [this dict](https://github.com/ethereum/web3.py/blob/c48c8cb25be01562d4ac094617a2ba543362843b/web3/_utils/method_formatters.py#L649-L653), and adding some tests.

Depending on how much work this ends up being for each method, it might make sense to split into 2 PRs.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.