ApeWorX / ApeWorX/web3.py

Core Test Cleanups

Open
#2,460 0 comments 0 reactions 0 assignees View on GitHub
priority: p3 nice to have
Dominant language
Python
Stars
5.5k
Forks
1.7k
Avg merge
3d 10h
Merged PRs (30d)
2

Description

### What was wrong?

There are some test cleanups that we'd like to look into.

### How can it be fixed?

Some ideas which should probably be separate PRs if implemented:

- explore the possibility of sharing contracts between `async_w3` and `w3`.
- explore `skip_if_testrpc`. Decide if they add enough documentation to keep around, or if documentation should be moved to the docs.
- explore which tests (if any) can be removed from the async core tests
- split async core tests into a separate tox run
- some of the emitter fixtures (and maybe others?) are duplicated throughout the tests, explore correcting the scope of the fixtures

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.