ApeWorX / ApeWorX/web3.py

[feature request] web3.ens.resolve should take a block number

Open
#1,984 1 comment 0 reactions 0 assignees View on GitHub
priority: p3 nice to have
Dominant language
Python
Stars
5.5k
Forks
1.7k
Avg merge
3d 10h
Merged PRs (30d)
2

Description

* Version: 5.18.0
* Python: 3.9
* OS: osx

### What was wrong?

I am doing some analysis of some of my old transactions and noticed that `web3.ens.resolve` was returning the current address and not the address at the time of the transaction.

### How can it be fixed?

I think adding a `block_identifier` kwarg to `web3.ens.resolve` that gets passed to the `call` functions inside would be a simple addition that would be backwards compatible.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.