ApeWorX / ApeWorX/web3.py

Allow `Method` to short circuit the JSON-RPC request if needed

Open
#1,795 0 comments 0 reactions 0 assignees View on GitHub
priority: p2 normal
Dominant language
Python
Stars
5.5k
Forks
1.7k
Avg merge
3d 10h
Merged PRs (30d)
2

Description

### What was wrong?
The `filter` method on the Eth module doesn't make a JSON-RPC request if a filter_id is passed in. The Method class doesn't make it easy to skip the method call if needed. The current solution is to raise and then catch an error right before the request is made, but this isn't an ideal long-term solution.

### How can it be fixed?

Piper made a suggestion for a solution [here](https://github.com/ethereum/web3.py/pull/1778#discussion_r525260729), which is probably the best place to start.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.