ApeWorX / ApeWorX/web3.py

Move the weighted gas price strategy under `web3.tools`

Open
#1,641 3 comments 0 reactions 0 assignees View on GitHub
priority: p3 nice to have
Dominant language
Python
Stars
5.5k
Forks
1.7k
Avg merge
3d 10h
Merged PRs (30d)
2

Description

related to #1463

### What was wrong?

I believe that the weighted gas price strategy should be deprecated or moved to live under `web3.tools`. This is based on the high subjectivity of gas prices which I believe means that we will be unable to supply gas price strategies that work well across the many disparate use cases that Web3.py is intended for.

### How can it be fixed?

The most extreme approach would be to deprecate and remove it. I'm not convinced this is the right choice.

I believe that the following course of action would be appropriate.

1. Move the weighted gas price strategy to live somewhere under `web3.tools`. This serves to designate this as not being part of the core library API, and thus to not be subject to as stringent of requirements for things like breaking changes.
2. Review our documentation around gas price strategies. Make sure that it is sufficiently informative so that someone could write their own gas pricing strategy that would serve their own needs.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.