ApeWorX / ApeWorX/web3.py

Move ExactLengthBytesEncoder to eth-abi

Open
#1,455 4 comments 0 reactions 0 assignees View on GitHub
priority: p2 normal
Dominant language
Python
Stars
5.5k
Forks
1.7k
Avg merge
3d 10h
Merged PRs (30d)
2

Description

* Version: 5.x

### What was wrong?
In order to support ABI encoding of bytes types of a specific length, a new encoder class had to be added. This class really belongs in the eth-abi library but was placed in web3 for the time being so that new eth-abi releases aren't needed for small changes. Once some time has passed, and we haven't seen issues raised with the API, it can be moved over.

### How can it be fixed?

We should be able to pretty much copy/paste the whole class over to eth-abi. We will also need a new exact bytes length specific decoder, like was added in PR #1419.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.