ApeWorX / ApeWorX/web3.py

Clearer error on contract execution error during call()

Open
#1,002 7 comments 0 reactions 0 assignees View on GitHub
Good First Issue priority: p2 normal
Dominant language
Python
Stars
5.5k
Forks
1.7k
Avg merge
3d 10h
Merged PRs (30d)
2

Description

### What was wrong?

When a contract error happens during a call, usually we let the eth-abi exception raise through. This makes users think that web3.py is broken. eg~ https://github.com/ethereum/web3.py/issues/185

### How can it be fixed?

After checking that there is code at the contract address, raise a `ContractError` indicating that something went wrong in the execution of the contract, so it didn't return any value at all.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.