ApeWorX / ApeWorX/py-solc-x

Solcx installs x86 binary on M1 Mac

Open
#152 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
142
Forks
50
PR merge metrics
No merged PRs in 30d

Description

### Environment information

* `py-solc-x` Version: 1.1.1
* `solc` Version: attempting to install latest (0.8.15)
* Python Version: 3.10.5
* OS: macOS 12.4

### What was wrong?

Installed py-solc-x and tried to install latest solc via:

```python
>>> import solcx
>>> solcx.install_solc()
```

Ended up with:

image

### How can it be fixed?

It seems a few years back there was a [PR to fix a similar issue](https://github.com/iamdefinitelyahuman/py-solc-x/pull/82), and automatically compile solc from source on ARM computers like the M1 Macs. At some point later, however, it seems like the download URL was hardcoded to the path of the `amd64` binary and the specific `_install_solc_arm()` function removed in later commits db7c859ecd7d8a657ec0475af7a54e98ac844bd1, 54eb45235c8283ec6fd64e0ccff3de4fb4228172

With the original fix from the PR, the path for ARM installation was to just compile solc from source. I imagine this route can be taken again, it just needs to be added to the branch that runs for macOS installation.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.