AnswerDotAI / AnswerDotAI/sqlite-minutils

Address last use of get_last_rowid

Open
#47 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
17
Forks
9
PR merge metrics
No merged PRs in 30d

Description

The `get_last_rowid` function is being called [here](https://github.com/AnswerDotAI/sqlite-minutils/blob/main/sqlite_minutils/db.py#L276-L279) in `insert_chunk`: https://github.com/AnswerDotAI/sqlite-minutils/blob/main/sqlite_minutils/db.py#L2992

That means that inserts are still vulnerable to corruption due to concurrency, transactions, and vacuums.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.