AnswerDotAI / AnswerDotAI/nbdev

Interested in Windows support?

Open
#1,584 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
5.3k
Forks
513
Avg merge
2d 30m
Merged PRs (30d)
8

Description

The README says Windows is not supported. Locally I did a port with pretty minor changes to make everything fully cross-platform. Is this something you would be interested in?

Rough list of things that needed to change:
- Gate `os.chmod` in git hook installation
- Use `encoding="utf-8"` everywhere explicitly
- Specify `newline="\n"` for generated artifacts (otherwise you will get CRLF on Windows and LF on Unix)
- There are a lot of `Path.write_text` which needed to be rewritten to `Path.write_bytes` because your `pyproject.toml` lists Python 3.9 as the minimum version and `newline="\n"` was added in 3.10. Your CI tests from 3.10 onwards, so bumping could simplify a lot.
- Remove reliance on `shell=True` in a few places (`cd tmp && xxx` replaced with `cwd=tmp`)
- Handle quarto installation through `winget` on Windows
- Minor changes to get the tests to run correctly

There are some dependencies that could use the newline parameter for writing (nb_write) and then everything would be consistent across platforms.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.