AnswerDotAI / AnswerDotAI/ghapi

Issues in the api wrappers while downloading logs

Open
#119 1 comment 2 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
685
Forks
70
Avg merge
1m
Merged PRs (30d)
2

Description

Hi, I stumbled upon this 2 bugs while trying out your project. It seems to me that those 2 functions that present the issue (`actions.download_workflow_run_logs` and `actions.list_jobs_for_workflow_run`) are working under the assumption that they're going to receive json, which is not the case. The first will receive a zip file (in the form of a byte array), while the second will receive the raw logs in the body of the response.

To reproduce:
```python
from ghapi.all import GhApi

api = GhApi(owner='fastai', repo='fastcore')
res_runs = api.actions.list_workflow_runs_for_repo(status='completed',per_page=5,page=1) # last 5 workflow_runs of your proj

for run in res_runs.workflow_runs.items:
try:
res = api.actions.download_workflow_run_logs(run.id) # gets a zip (byte array)
except Exception as bug1:
print(bug1)

res_jobs = api.actions.list_jobs_for_workflow_run(run_id=run.id)
for job in res_jobs.jobs.items:
try:
res = api.actions.download_job_logs_for_workflow_run(job.id) # gets plain text
except Exception as bug2:
print(bug2)
```

The problem to me seems that the `urlsend()` method in the fastcore dependency does not care about the response type, but tries to json decode the content, no matter what. Which fails because the `Content-Type` is, respectively, `plain/text` and `application/zip`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.