AnswerDotAI / AnswerDotAI/fastprogress

force_console_behavior does not modify behavior

Open
#103 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
1.1k
Forks
104
Avg merge
1m
Merged PRs (30d)
1

Description

Hi there, I am confused about the `force_console_behavior` function, it does _not_ force any behavior itself, it simply returns the console master and progress bars. I can't tell if it is misnamed or this is a regression.

fastai `ProgressCallback` uses the `master_bar` imported from `fastprogress`, so to force console the `master_bar` and `progress_bar` variables should be updated.

The current implementation is:

```
#export
def force_console_behavior():
"Return the console progress bars"
return ConsoleMasterBar, ConsoleProgressBar
```

I would expect this instead:

```
#export
def force_console_behavior():
master_bar = ConsoleMasterBar
progress_bar = ConsoleProgressBar
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.