AnswerDotAI / AnswerDotAI/fastlite

Patch brakes the argument order

Open
#33 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
232
Forks
19
PR merge metrics
No merged PRs in 30d

Description

Hi!

[This particular patch](https://github.com/AnswerDotAI/fastlite/blob/e4650c3700916e5adcbcb8110b29b7a24fc7334c/fastlite/kw.py#L120) provides a subset of the original arguments. I can live with that theoretically, but it also swaps the positions of `pk_items` and `updates`. It took some time to find why my `.update(id, {"a": "b"})` was broken 🙈 And the fact than my IDE (PyCharm) shows me hints about the original method and "go to definition" also jumps to the old one, doesn't help with such cases.

I understand that that "@patch"ing stuff was made for the sake of nbdev and it works in live environments. But such quirks with incompatibly changed method signatures make using of FastHTML in a Starlett's typical "hot reload" workflow pretty uncomfortable 😩

Maybe You can consider to make the args "keyword-only"? This will make the patching more robust.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.