AnswerDotAI / AnswerDotAI/fasthtml

[BUG] Potential SortableJS collision with touch devices

Open
#449 1 comment 0 reactions 2 assignees Claimed by @audreyfeldroy View on GitHub
bug
Dominant language
Jupyter Notebook
Stars
7k
Forks
319
Avg merge
28m
Merged PRs (30d)
3

Description

**Describe the bug**

1. adv_app.py doesn't work that well with Chrome on touch devices (Pixel, Samsung)
2. `SortableJS.create` allows arguments for touch devices that might fix the problem, but `proc_htmx` doesn't have a means to pass arguments

**Minimal Reproducible Example**

Stock `adv_app.py` deployed will demonstrate these problems on chrome touch:

1. With Touch it is very hard to click on any link that is in a sortable list
2. With Touch it is challenging to get sorting to work

**Expected behavior**

What should happen is:

- links only take one time to click
- sorting works reliably

**Environment Information**

- fastlite version: 0.1.1
- fastcore version: 1.7.9
- fasthtml version: 0.6.5

**Confirmation**
Please confirm the following:
- [x] I have read the FAQ (https://docs.fastht.ml/explains/faq.html)
- [x] I have provided a minimal reproducible example
- [x] I have included the versions of fastlite, fastcore, and fasthtml
- [x] I understand that this is a volunteer open source project with no commercial support.

**Screenshots**

Video recorded by @audreyfeldroy showing the problem: https://discord.com/channels/1200111522916094103/1287703999512051776/1287771376769433704

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.