AnswerDotAI / AnswerDotAI/fastcore
shouldn't `rnum_methods` and `inum_methods` be set in `fastuple`?
- Dominant language
- Jupyter Notebook
- Stars
- 1.1k
- Forks
- 295
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 7
Description
Noticed that `rnum_methods` and `inum_methods` are exported but never set into `fastuple`:
https://github.com/fastai/fastcore/blob/f7fea257626106e2016d4a55d280f8b876f6dcb4/fastcore/basics.py#L795
Shouldn't it be:
```py
for n in num_methods + rnum_methods +inum_methods:
if not hasattr(fastuple, n) and hasattr(operator,n): setattr(fastuple,n,_get_op(n))
```
?
Contributor guide
Research direction
Inspect fastcore/basics.py around line 795, focusing on how num_methods, rnum_methods, and inum_methods are exported into fastuple. Confirm the missing methods are available through operator and verify the resulting fastuple attributes with the project's existing tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100