AndrewBurian / AndrewBurian/eventsource

Event API Change

Open
#3 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
33
Forks
4
PR merge metrics
No merged PRs in 30d

Description

I think the call to `func (e *Event) Write(p []byte) (int, error) {` should not convert to a string; it should just do what `WriteRaw` does, and then remove `WriteRaw`. Having it actually convert to a string and do all the checks is not the expected behaviour (the caller has `WriteString` for that purpose).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.