AmigaLabs / AmigaLabs/SDK-Addon

Update SDK:s/cmake-startup for next release with cmake included

Open
#2 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
2
Forks
0
PR merge metrics
No merged PRs in 30d

Description

For the next SDK-Addon release that includes cmake, please update `SDK:s/cmake-startup`.

**Issue:**
abc-shell uses a hardcoded PATH if no PATH environment variable is set. If there is a PATH environment variable, abc-shell will use it without modification. Since most users do not set a custom PATH, `cmake-startup` will override abc-shell's path and render it useless. This needs to be addressed before the release.

**Example:**
```
3. > RAM Disk: > setenv PATH /cmake-amiga/bin
3. > RAM Disk: > sh
/RAM Disk> echo $PATH
/cmake-amiga/bin
```

**Solution:**
One solution would be to set the complete default PATH if there is no PATH env in `cmake-startup`:
```
assign cmake-amiga: SDK:cmake

GetEnv >NIL: *>NIL: PATH
If WARN
setenv PATH /cmake-amiga/bin:/gcc/bin:/SDK/C:/SDK/Local/C:/SDK/Local/newlib/bin:/SDK/Local/clib2/bin:/C:.
Else
setenv PATH /cmake-amiga/bin:${PATH}
EndIf

path ADD cmake-amiga:bin
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.