Altinn / Altinn/app-lib-dotnet

Replace all the hardcoded task type and action string comparisons

Open
#1,132 0 comments 0 reactions 0 assignees View on GitHub
kind/chore status/draft status/triage
Dominant language
C#
Stars
8
Forks
27
Avg merge
1h 21m
Merged PRs (30d)
7

Description

### Description

We have a bunch of code that checks task types and actions using inline strings, and they are duplicated all over the codebase.

Example: `checkedAction == "reject"`.

Replace these strings with something nicer. Value objects or static read only strings, or something...

Anything.

### Additional Information

Probably want to do it in storage interfaces package, since storage also has the same kind of strings.

### Acceptance Criterias

All cases are removed.

Contributor guide

Open the contributing guide

Research direction

Start by searching the codebase for inline task type and action comparisons such as `checkedAction == "reject"`, then inspect the storage interfaces package where similar strings are reported. Decide on a consistent replacement approach and verify that all such cases have been removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.