Altinn / Altinn/app-frontend-react

Delete button is always gone in repeating groups when hideTable is enabled

Open
#716 1 comment 0 reactions 0 assignees View on GitHub
kind/feature-request org/brg status/for-consideration
Dominant language
TypeScript
Stars
21
Forks
33
Avg merge
6d 23h
Merged PRs (30d)
3

Description

### Description

The delete button is by default visible in repeating groups, but even with the property `deleteButton` set to True, it will not be visible if the mode is set to `hideTable`.

This means that if a user adds another entry to the list by mistake, they will not be able to get out of it unless they fill out the whole group in such a way that validation on save works, or they refresh the page.

Neither of these are good solutions, and a lot of users would simply be stuck - at a loss for what to do.

### Additional Information

Example case where delete button is missing:
![image](https://user-images.githubusercontent.com/22012997/205972828-deaf894b-07f2-4706-82e2-44a5b06e53b5.png)
![image](https://user-images.githubusercontent.com/22012997/205972867-81781259-576f-4f0d-ba7e-f23e0d7f2fea.png)

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the repeating-group case with mode set to hideTable and deleteButton set to True, then search the frontend code for those property names and the delete control. Done means the delete button remains visible in hideTable mode and allows an accidentally added entry to be removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.