Altinn / Altinn/app-frontend-react

Refactor components to app-components

Open
#2,616 0 comments 0 reactions 0 assignees View on GitHub
Epic quality/debt
Dominant language
TypeScript
Stars
21
Forks
33
Avg merge
6d 23h
Merged PRs (30d)
3

Description

### Description

As decided in the ADR in this PR:

https://github.com/Altinn/app-frontend-react/pull/2593

we will refactor our components into dumb UI components.

Please see the ADR for the reasons for this.

### In scope

For each of our layout components:

1. Create a 'dumb' component in the `/src/app-components` folder
2. The component should receive and display data, receive and display isValid status.
3. The component should not have any dependencies on the rest of the app, it should be able to be moved out of src as a lib at any time.
4. There should remain a slim component inside /layout that resolves the data for the compoment, and communicates with the rest of the app.
5. The functionality should largely remain the same as before, meaning the tests should pass, unless we find improvents.

### Out of scope

_No response_

### Additional Information

_No response_

### Tasks

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by reading the ADR in pull request #2593 and reviewing the existing layout components. For each component, inspect the corresponding paths under /layout and /src/app-components, then check the current tests. Done means dumb UI components receive data and isValid without app dependencies, while slim /layout components resolve data and existing tests continue to pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.