Altinn / Altinn/altinn-authentication

BUG: Change request - 500 internal server error if resource not found

Open
#963 1 comment 0 reactions 1 assignee View on GitHub

@Nyeng is already working on this.

Since Jan 2, 2025.

Etter19JuniRelease onboarding candidate :handshake:
Dominant language
C#
Stars
8
Forks
6
Avg merge
2d 21h
Merged PRs (30d)
21

Description

Reproduksjonssteg og Generell Info

1 Create system with two rights
2. Create System user with one right.
3. Create Change request adding one new right (which doesn't exist)
{ "requiredRights": [ { "resource": [ { "id": "urn:altinn:resource", "value": "authentication-e2e-test" }, { "id": "urn:altinn:resource", "value": "resource-does-not-exist" } ] }
4. Approve change request gives500 internal server error: (Application insights link)

Forventet oppførsel

400 bad request eller 404? Skal dette skje i change requesten før du approver I frontend?

Faktisk oppførsel

500 internal server error

Logger og/eller direkte lenke til Application Insights
https://portal.azure.com/#view/AppInsightsExtension/DetailsV2Blade/ComponentId~/%7B%22SubscriptionId%22%3A%22de41df22-8dd0-435b-98dd-6152cd371e92%22%2C%22ResourceGroup%22%3A%22altinnplatform-at22-rg%22%2C%22Name%22%3A%22at22-platform-ai%22%2C%22LinkedApplicationType%22%3A0%2C%22ResourceId%22%3A%22%252Fsubscriptions%252Fde41df22-8dd0-435b-98dd-6152cd371e92%252FresourceGroups%252Faltinnplatform-at22-rg%252Fproviders%252FMicrosoft.Insights%252Fcomponents%252Fat22-platform-ai%22%2C%22ResourceType%22%3A%22microsoft.insights%252Fcomponents%22%2C%22IsAzureFirst%22%3Afalse%7D/DataModel~/%7B%22eventId%22%3A%22938c79e0-c8e9-11ef-b8e1-000d3a879cad%22%2C%22timestamp%22%3A%222025-01-02T09%3A10%3A49.559Z%22%2C%22cacheId%22%3A%228bd8057b-c2e8-47bb-899b-e76039e87757%22%2C%22eventTable%22%3A%22requests%22%7D
Testmiljø

AT22

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.