Altinity / Altinity/clickhouse-operator
Bug: table migration failure doesn't return error
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 2.6k
- Forks
- 574
- Avg merge
- 8d 6h
- Merged PRs (30d)
- 6
Description
Hi team, we're deploying clickhouse in kubernetes cluster with this project. One thing we found weird is, in rare cases we suffer error messages like There is no table xxx on server, which indicates a missing schema population issue.
When checking the source code, I found on table migration failure, we only log error messages but not return error.
IIUC, during reconciliation, if we ignore the migration failure, certain host status will be transitioned from "Requested" to "Success", then serve traffic and suffer schema errors.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the table migration failure in the reconciliation flow described in the issue, where the error is currently logged. Follow how reconciliation determines that a host is successful after migration, then verify that migration failure is propagated so the host cannot transition to Success; confirm the behavior with the relevant existing tests, if present.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- clickhouse, go, kubernetes
- Domain
- databases, infrastructure
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100