Altinity / Altinity/clickhouse-operator
Operator should add graceful shutdown to the pods
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 2.6k
- Forks
- 574
- Avg merge
- 8d 6h
- Merged PRs (30d)
- 6
Description
The ideal graceful flow would be:
- SYSTEM STOP MERGES -- no NEW merges start
- SYSTEM STOP FETCHES -- no NEW fetches (replication) start
- Wait for in-flight merges/fetches to finish
(query system.merges / system.replicated_fetches to check) - SYSTEM SHUTDOWN -- now safe to kill, nothing in progress
What the operator does today:
- SYSTEM SHUTDOWN -- everything in progress gets killed
Upgrades can cause some race condition with various setups.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how the operator currently shuts down ClickHouse pods. Compare that flow with the issue's SYSTEM STOP MERGES, SYSTEM STOP FETCHES, in-flight checks through system.merges and system.replicated_fetches, and final SYSTEM SHUTDOWN sequence. Done means upgrades no longer kill active merges or replication fetches during shutdown.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- databases, devops, infrastructure
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100