Altinity / Altinity/clickhouse-operator
Hardcoded default ClickHouse and Keeper images
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 2.6k
- Forks
- 574
- Avg merge
- 8d 6h
- Merged PRs (30d)
- 6
Description
The default ClickHouse and Keeper container images are hardcoded, see:
- https://github.com/Altinity/clickhouse-operator/blob/master/pkg/model/chi/config/const.go#L71
- https://github.com/Altinity/clickhouse-operator/blob/master/pkg/model/chk/config/const.go#L68
They should be customizable via env. variables (e.g. CLICKHOUSE_CONTAINER_IMAGE and KEEPER_CONTAINER_IMAGE) so these default values can be overwritten. AFAIK, only the env. vars defined below are currently supported.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with pkg/model/chi/config/const.go and pkg/model/chk/config/const.go, then read pkg/apis/deployment/env_vars.go to compare the existing supported environment variables. Trace how those variables are consumed and verify that CLICKHOUSE_CONTAINER_IMAGE and KEEPER_CONTAINER_IMAGE can override the current defaults while preserving them when unset.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- clickhouse, go, kubernetes
- Domain
- devops, infrastructure
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100