AlphaWallet / AlphaWallet/alpha-wallet-ios

Remove/fix code that does nothing with TokenHistoryChartView marker

Abierto
#6,279 3 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Swift
Estrellas
631
Forks
384
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

The following lines appear not to be needed. I commented out the code and was able to compile. Invoking it via the steps listed below appear not to cause any crashes.

https://github.com/AlphaWallet/alpha-wallet-ios/blob/2ccf9e5d573a3c56360902dda13771cb5f756118/AlphaWallet/Tokens/Collectibles/Views/TokenHistoryChartView.swift#L14-L18

https://github.com/AlphaWallet/alpha-wallet-ios/blob/2ccf9e5d573a3c56360902dda13771cb5f756118/AlphaWallet/Tokens/Collectibles/Views/TokenHistoryChartView.swift#L104

## Steps
1. From main wallet screen tap the search bar
2. Enter `erc20`
3. Tap any of the filtered assets
4. tap in the bar chart to get a square label that describes the date-time and price of the asset.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.