AlphaWallet / AlphaWallet/alpha-wallet-ios

Remove swap in activities

未关闭
#2,902 7 条评论 0 个 reaction 已指派 1 人 已指派给 @hboon 在 GitHub 查看
Enhancement
主要语言
Swift
星标
631
派生
384
PR 合并指标
30 天内没有已合并 PR

描述

What is the current logic behind showing Swap in activities? @hboon
![image](https://user-images.githubusercontent.com/33795543/122134167-6bd29d00-ce81-11eb-90cb-354c1b45c2b3.jpeg)

In many cases, it may look like a swap, but actually not. It is impossible to identify all the Swaps without manually pointing them out one by one. If we can not identify all of the Swaps and we may show the wrong Swap, this won't help with clarity and control at all, it just makes the user more confusing.

**Before TokenScript is adopted, I suggest using a standard way to show all the activities titles:
If the contract code is verified on Etherscan, show the activity title as Contract(or DApp) "contract name(contract address if no name)" function "xxxxx"
If the contract code is not verified on Etherscan, show the activity title as Contract(or DApp) "contract name(contract address if no name)" function**

By doing this, at least we know all the information in activities is correct, there won't be any misleading information.

@colourfreak what do you think?

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。