AllenNeuralDynamics / AllenNeuralDynamics/voxel-classic

Consider refactoring DAQ class to enable DAQ devices (i.e. AOTF laser + others)

Aperta
#27 0 commenti 0 reazioni 1 assegnatario Rivendicata da @waltermwaniki Vedi su GitHub
Lingua principale
Python
Stelle
4
Fork
3
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Right now, the DAQ class contains all of the information for tasks, AO channels, etc. We could consider refactoring this and instead embedding tasks/AO channels within devices themselves.

This would require passing the DAQ into the device. We could do this by first initializing the DAQ (just sampling rate, Dev name etc) and then passing this minimal DAQ into other devices. Perhaps these "DAQ" devices would be subdevices of the DAQ in the YAML. Or we could define them outside of the DAQ but have a different means of passing the DAQ in.

It is also possible to create many tasks on the DAQ. Right now we are creating one massive task for all of our devices. It may be more compatible with the above to define a dedicated task (named appropriately) for each device, within that device class that inherits the DAQ object. Hardware wise, the only requirement is that there is one task for each multiple of 4 AO channels. So AO0-3 can only contain one task, etc.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.