AllenNeuralDynamics / AllenNeuralDynamics/aind-dynamic-foraging-basic-analysis

Remove dependency on aind_ephys_utils

Offen
#9 0 Kommentare 0 Reaktionen 1 zugewiesene Person Beansprucht von @ZhixiaoSu Auf GitHub ansehen
Vorherrschende Sprache
Python
Sterne
1
Forks
0
Ø Merge
8 T. 19 Std.
Gemergte PRs (30 T.)
1

Beschreibung

**Is your feature request related to a problem? Please describe.**
This repository should contain basic analyses that are not dependent on ephys data. However the pyproject.toml includes a dependency on `aind_ephys_utils`. As far as I can tell, this is only used for aligning (https://github.com/AllenNeuralDynamics/aind-dynamic-foraging-basic-analysis/blob/7ddd5e95b6ec23cf4497d3b74c3083b668c7a271/src/aind_dynamic_foraging_basic_analysis/lick_analysis.py#L554). However we have created generic alignment tools in https://github.com/AllenNeuralDynamics/aind-dynamic-foraging-data-utils/blob/main/src/aind_dynamic_foraging_data_utils/alignment.py

**Describe the solution you'd like**
If the aind-ephys-utils contains alignment tools not in aind_dynamic_foraging_data_utils, they should be moved to the data_utils. If they alignment tools are redundant, we should use data_utils, to reduce the dependency

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.