AllenInstitute / AllenInstitute/bmtk
Many examples won't work if config file is not specified in Python 3.9+
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 335
- Forks
- 102
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 6
Description
Many examples under examples/ use the following line to set the 'default' config file.
if __file__ != sys.argv[-1]:
However, in Python 3.9+, this won't work because __file__ is an absolute path.
An easy way to fix it will be using something like:
if sys.argv[-1] in __file__:
Or, alternatively, we can change __file__ to os.path.basename(__file__).
There might be a better idea, so making an issue to discuss.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the examples/ files that contain if __file__ != sys.argv[-1]: and compare how they determine the default config file under Python 3.9+. Choose a consistent fix for these examples, then verify that each works when no config file is specified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100