AllenInstitute / AllenInstitute/MIES
Problematic decimation in DC_PlaceDataInITCDataWave
Nobody has claimed this yet.
- Dominant language
- IGOR Pro
- Stars
- 30
- Forks
- 11
- Avg merge
- 1d 40m
- Merged PRs (30d)
- 8
Description
Sampling rate gets decimated by MultiThread ITCDataWave[singleInsertStart, singleInsertStart + singleSetLength - 1][activeColumn] = limit(TTLWave[decimationFactor * (p - singleInsertStart)], SIGNED_INT_16BIT_MIN, SIGNED_INT_16BIT_MAX) which basically just drops sample points in TTLWave.
Better: Apply digital filter that limits frequency to f(ITCDataWave)/2 with a step function.
See https://en.wikipedia.org/wiki/Decimation_(signal_processing)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at DC_PlaceDataInITCDataWave and inspect the decimation expression that reads TTLWave into ITCDataWave. Read the linked decimation reference to determine the required digital-filter behavior and define how the frequency limit and step function should be validated. Done means decimation no longer only drops sample points and the resulting signal meets the stated frequency limit.
Written by the indexing model from the issue text.
Assessment
- Domain
- data
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100