AllenInstitute / AllenInstitute/MIES
PulseAveraging: Review GUI -> execution order relation of processing for all modes
Nobody has claimed this yet.
- Dominant language
- IGOR Pro
- Stars
- 30
- Forks
- 11
- Avg merge
- 1d 40m
- Merged PRs (30d)
- 8
Description
This chart shows the current execution order in POST_CONSTANT_SWEEPS mode when a GUI control gets enabled.
Some unnecessary function calls are marked "wrong". Another thing that should be reviewed is if ResetWavesIfRequired has to be called when previously GenerateAllPulseWaves was called. The argument is that in POST_CONSTANT_SWEEPS either none or all sweeps were generated anew, so no call to Reset should be required.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the attached PA_calling_order.zip chart and trace the PulseAveraging GUI-enable flow in POST_CONSTANT_SWEEPS mode. Compare calls marked “wrong” and check whether ResetWavesIfRequired is still needed after GenerateAllPulseWaves; done means the execution order and reset behavior are reviewed consistently across all modes.
Written by the indexing model from the issue text.
Assessment
- Domain
- desktop
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100