AllenInstitute / AllenInstitute/MIES

PulseAveraging: Scale of deconvolution data is wrong

Open
#736 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Backlog bug PA plot
Dominant language
IGOR Pro
Stars
30
Forks
11
Avg merge
1d 40m
Merged PRs (30d)
8

Description

In PA_Deconvolution the deconvolution is calculated using the difference between the n + 1 and nth point into a wave that is one point shorter than the (smoothed) average wave. However the scale is not shifted 0.5 points to the right.

The result is that the deconvolution data is displayed half a point offsetted to the left and induces that the last points in the image plot are NaN.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the PA_Deconvolution entry point and trace how the difference wave is assigned its scale relative to the smoothed average wave. Verify the corrected half-point alignment in the image plot and confirm that the final plotted values are no longer NaN.

Written by the indexing model from the issue text.

Assessment

Domain
data-visualization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.