AllenInstitute / AllenInstitute/MIES

Skip sweeps is not robust

Open
#654 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Backlog bug DataAcquisition
Dominant language
IGOR Pro
Stars
30
Forks
11
Avg merge
1d 40m
Merged PRs (30d)
8

Description

I just realized while writing the new spike control analysis function that if you combine multiple calls to RA_SkipSweeps you are never finishing.

Doing in the first sweep RA_SkipSweeps(panelTitle, -1) and then in the next one RA_SkipSweeps(panelTitle, inf, limitToSetBorder=1) results in endless data acquisition.

I suspect that the activeSetCount is wrong.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at RA_SkipSweeps and trace how activeSetCount is updated across successive calls. Reproduce the two-sweep sequence using -1 followed by inf with limitToSetBorder=1; done means acquisition terminates instead of continuing endlessly.

Written by the indexing model from the issue text.

Assessment

Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.