AllenInstitute / AllenInstitute/MIES

Enhance ITI accuracy

Open
#33 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Backlog DataAcquisition Testpulse
Dominant language
IGOR Pro
Stars
30
Forks
11
Avg merge
1d 40m
Merged PRs (30d)
8

Description

  • Don't ignore the time DC_ConfigureDataForITC takes in RA:
    A totally crazy idea: Why do we not call DC_ConfigureDataForITC(panelTitle,
    DATA_ACQUISITION_MODE) before we start waiting for the ITT elapse? This would
    not require any guessing about the config time from our part we just would have
    to keep separate ITCDataWaves and ITCConfigWaves for DAQ and TP. As we need to
    configure DAQ before TP.
    • GetITCDataWave and friends would get a dataAcqOrTP parameter like
      DC_UpdateGlobals and create the wave either in
      MIES:ITCDevices:ITC18USB_DEV or MIES:ITCDevices:ITC18USB_DEV:TestPulse
    • Most of the code in RA_CounterMD and RA_Counter has to be moved and done
      in RA_HandleITI before we can fill the ITCDataWave for DAQ and before we
      can start TP.
    • In ITC_StartDAQMultiDeviceLowLevel we need to pull out the DC_ConfigureDataForITC calls.
      See also the discussion in PR 459 (AI stash)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with RA_HandleITI, RA_CounterMD, RA_Counter, ITC_StartDAQMultiDeviceLowLevel, and the GetITCDataWave functions named in the issue. Read the discussion in PR 459 for context on separating DAQ and TP configuration and data waves. Done means ITC configuration time is handled without guessing and DAQ and TP use the proposed separate waves and sequencing.

Written by the indexing model from the issue text.

Assessment

Domain
data
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.