AllenInstitute / AllenInstitute/MIES
Improve handling of missing epochs in `epochs`
Nobody has claimed this yet.
- Dominant language
- IGOR Pro
- Stars
- 30
- Forks
- 11
- Avg merge
- 1d 40m
- Merged PRs (30d)
- 8
Description
From https://github.com/AllenInstitute/MIES/pull/2109#issuecomment-2299197116:
Problem with missing epochs could be solved like this: If no wildcard patterns are used in the textual epoch specification for epochs() then we can keep non-existing epochs as empty ranges. e.g. for sweep 18 we would return a (2,2) array where the range for E2 is [NaN,NaN]. Then in data() we skip sweep data extraction if the current range evaluated is [NaN,NaN].
If wildcards are used for epoch names in epochs we can not do that because we do not know how many matches we get for each sweep. We also do not know how the matches order up, such that a "auto indexed" addition may hit on unrelated ranges.
and from https://github.com/AllenInstitute/MIES/pull/2109#issuecomment-2318555483:
skipping over missing epochs - using the full stimset name is okay (rather than wildcards), especially if there were a way to pass the acquired stimulus set names over zeroMQ
Generate a warning when data is missing
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the epochs() and data() entry points, focusing on textual epoch specifications with and without wildcard patterns. Confirm how missing epochs are represented and how sweep data extraction handles [NaN,NaN] ranges; done means non-wildcard missing epochs are skipped safely and missing data produces a warning.
Written by the indexing model from the issue text.
Assessment
- Domain
- data
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100