AllenInstitute / AllenInstitute/MIES
Allow to write tests with pressure devices
Nobody has claimed this yet.
- Dominant language
- IGOR Pro
- Stars
- 30
- Forks
- 11
- Avg merge
- 1d 40m
- Merged PRs (30d)
- 8
Description
We don't yet have tests for the pressure control code, the line coverage for MIES_PressureControl.ipf is therefore only 24% 1. As recent issues have shown https://github.com/AllenInstitute/MIES/issues/2124, and also the additional fix required for https://github.com/AllenInstitute/MIES/pull/2137#issuecomment-2221695295, this ain't good.
For being able to write tests using pressure control we would need a NI USB 6001 at all CI machines with hardware attached. If something has to be bought we might also buy three to prepare for a future separate machine for ITC1600 and NI.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with MIES_PressureControl.ipf and the linked coverage report to understand the untested pressure-control paths. Review the CI hardware requirement for NI USB 6001 devices and the referenced issue and pull-request discussion; done would mean pressure-control tests can run reliably on CI machines.
Written by the indexing model from the issue text.
Assessment
- Domain
- ci-cd, infrastructure, testing
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100