AllenInstitute / AllenInstitute/MIES
Ideas to speedup SweepFormula selrac, selsci
Nobody has claimed this yet.
- Dominant language
- IGOR Pro
- Stars
- 30
- Forks
- 11
- Avg merge
- 1d 40m
- Merged PRs (30d)
- 8
Description
First #2154 should be resolved.
-
For RAC currently over all initial selections is iterated, but it only needs to iterate over all unique sweep numbers per experiment/datafolder/device.
-
RAC and SCI result in new additional selections. These new selections can contain selections that are identical to initial selections. If that is the case then we know that these selections are already of the same RAC or SCI. Thus, we could skip
AFH_GetSweepsFromSameSCI/AFH_GetSweepsFromSameRACyclefor initial selections that we already got as a result of a previous request.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
First review issue #2154, which the issue says must be resolved before this work. Then trace the sweep-number iteration and the AFH_GetSweepsFromSameSCI and AFH_GetSweepsFromSameRACycle entry points. Done means avoiding unnecessary iteration and repeated lookups for duplicate selections while preserving RAC and SCI results.
Written by the indexing model from the issue text.
Assessment
- Domain
- performance
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100