AllenInstitute / AllenInstitute/MIES
DC_PrepareLBNEntries should prefer DataConfigurationResult entries vs. re-getting the same data from the GUI
Nobody has claimed this yet.
- Dominant language
- IGOR Pro
- Stars
- 30
- Forks
- 11
- Avg merge
- 1d 40m
- Merged PRs (30d)
- 8
Description
DC_PrepareLBNEntries retrieves data for LNB entries from the GUI that actually have entries in DataConfigurationResult.
Here the filled structure should be preferred because
-
we write only data in the LNB that is actually evaluated by DC
-
no re-getting of data from the GUI in the same module
-
DC_PrepareLBNEntries should be like one of the "inverse" functions in the concept of the upcoming feature to recreate the DataConfigurationResult structure from the LNB.
-
DC_CalculateChannelColumnNo should also be cleaned up
-
Check usage of s.indexingLocked, seems not to be filled in DC and not read. It is only read from GUI and written to LNB. Should go through s aswell then?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating DC_PrepareLBNEntries and DC_CalculateChannelColumnNo, then trace how DataConfigurationResult, the GUI, and the LNB are used. Check the handling of s.indexingLocked alongside these paths. Done means LNB entries use the evaluated DataConfigurationResult data without re-fetching it from the GUI, with the related cleanup completed.
Written by the indexing model from the issue text.
Assessment
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100