AllenInstitute / AllenInstitute/MIES

Fix effective stimset size extension with ITC and multiple TTL channels with different length stimsets

Open
#2,007 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug DataAcquisition
Dominant language
IGOR Pro
Stars
30
Forks
11
Avg merge
1d 40m
Merged PRs (30d)
8

Description

Only on ITC:
If multiple TTL channels are used with different size stimsets then the decimation uses the joined TTL data and decimates over the maximum stimset size. Depending on the decimation factor this leads to an extension of the shorter stimset in the data wave.

Steps to solve:

  • Change logic for ITC to have single channel TTL waves, if possible use same code paths as NI.
  • In DC_WriteTTLIntoDAQDataWave use a for loop over the single TTL channels of a rack and join the TTL data in ITCDataWave, use for each single TTL channel the setLength specific for that channel. From singleSetLength = DC_CalculateStimsetLength(TTLWaveSingle, device, DATA_ACQUISITION_MODE)
  • revert the handling of that case in epoch creation

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in DC_WriteTTLIntoDAQDataWave and trace the ITC path, including DC_CalculateStimsetLength and epoch creation. Check how single TTL channels are handled and how ITCDataWave is assembled. Done means each channel uses its own stimset length and shorter stimsets are not extended by decimation over the maximum length.

Written by the indexing model from the issue text.

Assessment

Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.